-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom labels in createOneOfBlock
#2413
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a usage in Demo, either video block or media block
I think we need some kind of special solution to avoid tinting the icons. As you can notice in the screenshot the youtube icon (as well as the vimeo icon) should not be tinted with the selected (or not selected) tint color. |
The Tinting of the Icons appears to be a Comet problem and also appears on the Storybook Icons Page |
packages/admin/blocks-admin/src/blocks/factories/createOneOfBlock.tsx
Outdated
Show resolved
Hide resolved
@thomasdax98 maybe it's not a good idea to have colored versions of the brand icons after all. MUI also doesn't do this: https://mui.com/material-ui/material-icons/?query=youtu&selected=YouTube |
This PR has now 636 changed files and conflicts. Please fix, thanks! |
0c38888
to
9461c4e
Compare
We discussed this today with UX and decided to remove the tinting of the icons. @fichtnerma please remove them, thanks! |
…s for Vimeo and YouTube
createOneOfBlock
b574f9f
to
1d0d6ac
Compare
Add support for Icons and other ReactNodes for OneOfBlock Tab Labels
PR Checklist
Screenshots/screencasts