Styling and custom component for DataGrid
panels
#3033
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements theme-styling of the filter and column panels to more closely match the comet design.
No changes in the application are needed for this to take effect.
This also implements a custom
DataGridPanel
component which improves on the styling and enables the full-screen/mobile variants of the panels defined by the comet design.Due to
@comet/admin-theme
not having a dependency on@comet/admin
orreact-intl
the new component and the texts defined in the design must be added to the applications theme manually. This may be changed inv8
, as it's planned to move the theme from it's own package@comet/admin-theme
into the main@comet/admin
package.Example theme:
src/theme.ts
:Acceptance criteria
Screenshots
Custom
DataGridPanel
(preferred)MUIs default GridPanel (works out of the box)
Open TODOs/questions
DataGridPanel
customizableshrink={false}
instead of settingtransform: none
in the styling (filterForm
->inputLabelClasses.root
)Changed to be made in separate tasks/PRs:
createCometTheme()
– this may require merging the@comet/admin-theme
into the@comet/admin
package.Further information