Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo: Remove builder #3045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Demo: Remove builder #3045

wants to merge 1 commit into from
+9 −62

Conversation

dkarnutsch
Copy link
Contributor

@auto-assign auto-assign bot requested a review from johnnyomair January 7, 2025 16:50
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

johnnyomair
johnnyomair reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still support SSG as a legacy option. Is removing the builder a good idea?

@dkarnutsch
Copy link
Contributor Author

We still support SSG as a legacy option. Is removing the builder a good idea?

Yes, because we focus on SSR and the builder is not working locally.

@johnnyomair
Copy link
Collaborator

Yes, because we focus on SSR and the builder is not working locally.

How would I test changes to the builder module? Those could still be necessary, e.g., changes caused by updating the Kubernetes client. Re-add everything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@dkarnutsch dkarnutsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkarnutsch @johnnyomair