Migrate from deprecated @azure/openai package to openai
#3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdax98
commented
Jan 8, 2025
| return new AzureOpenAI({ | ||
| apiKey: config.apiKey, | ||
| deployment: config.deploymentId, | ||
| apiVersion: config.apiVersion ?? "2024-03-01-preview", |
There was a problem hiding this comment.
In the new library, apiVersion is a required field. In the old library, it wasn't required and the library had a default (see https://github.com/minhanh-phan/azure-sdk-for-js/blob/39b9c4251908c5eb60964cd8f7706fa2efd5e6b9/sdk/openai/openai/src/rest/openAIClient.ts#L22)
I copied this default and hope that it will continue to work. We can make the field required in v8
johnnyomair
reviewed
Jan 9, 2025
|
johnnyomair
approved these changes
Jan 10, 2025
stekalt
pushed a commit
that referenced
this pull request
Jan 15, 2025
Co-authored-by: Johannes Obermair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate from deprecated
@azure/openaipackage toopenaisee https://learn.microsoft.com/en-us/azure/ai-services/openai/how-to/migration-javascript for more info
Acceptance criteria
Screenshots/screencasts
Still works:
Uploading Bildschirmaufnahme 2025-01-08 um 11.41.01.mov…