-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration guide for brevo module v2 to v3 #3256
base: main
Are you sure you want to change the base?
Conversation
c456080
to
da30710
Compare
docs/docs/9-brevo-module/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in the Features/Modules section
Make sure, that your project is compatible with COMET v7: | ||
|
||
- Now requires >= v7.10.0 for @comet packages | ||
- Now requires >= 5.9.8 for @mikro-orm packages (except @mikro-orm/nestjs where >= 5.2.3 is required) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure, that your project is compatible with COMET v7: | |
- Now requires >= v7.10.0 for @comet packages | |
- Now requires >= 5.9.8 for @mikro-orm packages (except @mikro-orm/nestjs where >= 5.2.3 is required) | |
Make sure, that your project uses COMET v7.10.0 or later. |
We could even use a warning admonition here.
}); | ||
``` | ||
|
||
### Import `PublicUploadsModule` in the project's `AppModule` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The public uploads module has been rename to file uploads in Comet v7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I got it wrong from the changeset. It's correct in the code.
|
||
Install `@comet/brevo-mail-rendering` in your project's site. This package offers reuseable frontend components for rendering emails. | ||
|
||
Optional: You can use the `NewsLetterImageBlock` for rendering Images in your Newsletter campaigns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question: Is the casing really NewsLetter? Shouldn't it be Newsletter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's a typo - thanks!
Description
Add migration guide for updating brevo from v2 to v3
Acceptance criteria
Open TODOs/questions
Further information