Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration guide for brevo module v2 to v3 #3256

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Jan 22, 2025

Description

Add migration guide for updating brevo from v2 to v3

Acceptance criteria

Open TODOs/questions

  • Add changeset

Further information

@juliawegmayr juliawegmayr self-assigned this Jan 22, 2025
@juliawegmayr juliawegmayr force-pushed the migration-guide-for-brevo-module branch from c456080 to da30710 Compare January 22, 2025 15:51
@juliawegmayr juliawegmayr marked this pull request as ready for review January 22, 2025 16:14
@auto-assign auto-assign bot requested a review from johnnyomair January 22, 2025 16:14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the Features/Modules section

Comment on lines 5 to 8
Make sure, that your project is compatible with COMET v7:

- Now requires >= v7.10.0 for @comet packages
- Now requires >= 5.9.8 for @mikro-orm packages (except @mikro-orm/nestjs where >= 5.2.3 is required)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Make sure, that your project is compatible with COMET v7:
- Now requires >= v7.10.0 for @comet packages
- Now requires >= 5.9.8 for @mikro-orm packages (except @mikro-orm/nestjs where >= 5.2.3 is required)
Make sure, that your project uses COMET v7.10.0 or later.

We could even use a warning admonition here.

});
```

### Import `PublicUploadsModule` in the project's `AppModule`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public uploads module has been rename to file uploads in Comet v7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I got it wrong from the changeset. It's correct in the code.


Install `@comet/brevo-mail-rendering` in your project's site. This package offers reuseable frontend components for rendering emails.

Optional: You can use the `NewsLetterImageBlock` for rendering Images in your Newsletter campaigns.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: Is the casing really NewsLetter? Shouldn't it be Newsletter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's a typo - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants