Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validateWarning Story #3263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix validateWarning Story #3263

wants to merge 1 commit into from

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Jan 23, 2025 •
edited
Loading

Description

Problem: validateWarning only worked for email field, if the previous name was validated as well.

The form used two different functions for validateWarning. The validation for name was passed in the Form directly. The validation for the email was passed to the field, which caused the problem. It is possible to either pass the validateWarning to FinalForm or to the fields separately.

Acceptance criteria

Screenshots/screencasts

Before:

Screen.Recording.2025-01-23.at.14.37.33.mov

After:

Screen.Recording.2025-01-23.at.14.36.36.mov

Further information

@juliawegmayr juliawegmayr marked this pull request as ready for review January 23, 2025 13:52
@auto-assign auto-assign bot requested a review from johnnyomair January 23, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair Awaiting requested review from johnnyomair

@jamesricky jamesricky Awaiting requested review from jamesricky

At least 1 approving review is required to merge this pull request.

Assignees

@juliawegmayr juliawegmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juliawegmayr