Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid lock on graph uri update in RdfServiceSparql #424

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

litvinovg
Copy link
Contributor

VIVO GitHub issue

What does this pull request do?

Run RdfServiceSparql graph uri update in a separate thread to avoid lock the same way it was previously implemented in RDFServiceJena.

How should this be tested?

Test as in issue description:

  • Configure VIVO to use ContentTripleSourceSPARQL
  • Try adding/removing graph.

Interested parties

@VIVO-project/vivo-committers @chenejac @brianjlowe

@litvinovg litvinovg force-pushed the non-blocking-rdf-service-sparql branch from d323447 to a0a60cd Compare November 1, 2023 13:19
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg I have added two comments.

@litvinovg litvinovg requested a review from chenejac November 3, 2023 09:12
chenejac
chenejac previously approved these changes Nov 3, 2023
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg thanks

@chenejac chenejac requested a review from ivanmrsulja January 19, 2024 10:00
Copy link
Member

@ivanmrsulja ivanmrsulja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, looks good but I have left some suggestions that you may find helpfull.

@litvinovg
Copy link
Contributor Author

Hello, looks good but I have left some suggestions that you may find helpfull.

First 4 commits - the PR itself, 5th - style auto formatting.
Comments above not related to the code that was changed in this PR.

Copy link
Member

@brianjlowe brianjlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this refactoring looks good. Good to have the same behavior on the SPARQL service.

@chenejac chenejac merged commit fcf4398 into vivo-project:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants