There's no "union" function, use "intersect" #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the documentation says there's an "union" function that computes the union of two sets, looking at Hugo's source code, there's no such function. Use "intersect" instead. It's more appropriate, too, because it will eliminate duplicates in the two lists, if there are any. Signed-off-by: Marcelo E. Magallon <[email protected]>
|
Sorry, I didn't realize I had an old hugo binary in my path :-( But I still think it's better to use intersect than union. Would you like me to correct the commit message? |
|
Are you sure the behaviour of intersect == Union ? |
|
The functions are absolutely not equivalent. See https://gohugo.io/functions/intersect/ and https://gohugo.io/functions/union/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the documentation says there's an "union" function that computes
the union of two sets, looking at Hugo's source code, there's no such
function.
Use "intersect" instead. It's more appropriate, too, because it will
eliminate duplicates in the two lists, if there are any.
Signed-off-by: Marcelo E. Magallon [email protected]