Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.55 .URL deprecated,.RSSLink deprecated,use hugo global function #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nonumeros
Copy link

No description provided.

@nonumeros nonumeros changed the title v0.55 .URL deprecated,.RSSLink deprecated,uso hugo global function v0.55 .URL deprecated,.RSSLink deprecated,use hugo global function Apr 14, 2019
@halink0803
Copy link

halink0803 commented Oct 18, 2019

Did you tried to build a page with your changes? I tried but it failed with error:

Failed to render pages: render of "home" failed: "src/themes/casper/layouts/page/index.html:12:24": execute of template failed: template: page/index.html:1:3: executing "page/index.html" at <partial "header.html" .>: error calling partial: "/src/themes/casper/layouts/partials/header.html:12:24": execute of template failed: template: partials/header.html:123:5: executing "partials/header.html" at <partial "navigation.html" .>: error calling partial: "/src/themes/casper/layouts/partials/navigation.html:12:24": execute of template failed: template: partials/navigation.html:12:24: executing "partials/navigation.html" at <.Permalink>: can't evaluate field Permalink in type *navigation.MenuEntry

It seems this PR does not work.

@halink0803
Copy link

Actually, the problem is only with the navigation.html file, as the .Menu.URL is not deprecated. Only .Page.URL is deprecated.

@nonumeros
Copy link
Author

nonumeros commented Oct 18, 2019

Did you tried to build a page with your changes? I tried but it failed with error:

Failed to render pages: render of "home" failed: "src/themes/casper/layouts/page/index.html:12:24": execute of template failed: template: page/index.html:1:3: executing "page/index.html" at <partial "header.html" .>: error calling partial: "/src/themes/casper/layouts/partials/header.html:12:24": execute of template failed: template: partials/header.html:123:5: executing "partials/header.html" at <partial "navigation.html" .>: error calling partial: "/src/themes/casper/layouts/partials/navigation.html:12:24": execute of template failed: template: partials/navigation.html:12:24: executing "partials/navigation.html" at <.Permalink>: can't evaluate field Permalink in type *navigation.MenuEntry

It seems this PR does not work.

what hugo version did you run it with

if a site is created from scratch with 0.55,it works for me.

@halink0803
Copy link

Did you tried to build a page with your changes? I tried but it failed with error:

Failed to render pages: render of "home" failed: "src/themes/casper/layouts/page/index.html:12:24": execute of template failed: template: page/index.html:1:3: executing "page/index.html" at <partial "header.html" .>: error calling partial: "/src/themes/casper/layouts/partials/header.html:12:24": execute of template failed: template: partials/header.html:123:5: executing "partials/header.html" at <partial "navigation.html" .>: error calling partial: "/src/themes/casper/layouts/partials/navigation.html:12:24": execute of template failed: template: partials/navigation.html:12:24: executing "partials/navigation.html" at <.Permalink>: can't evaluate field Permalink in type *navigation.MenuEntry

It seems this PR does not work.

what hugo version did you run it with

if a site is created from scratch with 0.55,it works for me.

I tried with 0.55 and even update to 0.58, it is failed if you change .URL in navigation .Menu.URL.

@nonumeros
Copy link
Author

nonumeros commented Oct 21, 2019

Did you tried to build a page with your changes? I tried but it failed with error:

Failed to render pages: render of "home" failed: "src/themes/casper/layouts/page/index.html:12:24": execute of template failed: template: page/index.html:1:3: executing "page/index.html" at <partial "header.html" .>: error calling partial: "/src/themes/casper/layouts/partials/header.html:12:24": execute of template failed: template: partials/header.html:123:5: executing "partials/header.html" at <partial "navigation.html" .>: error calling partial: "/src/themes/casper/layouts/partials/navigation.html:12:24": execute of template failed: template: partials/navigation.html:12:24: executing "partials/navigation.html" at <.Permalink>: can't evaluate field Permalink in type *navigation.MenuEntry

It seems this PR does not work.

what hugo version did you run it with
if a site is created from scratch with 0.55,it works for me.

I tried with 0.55 and even update to 0.58, it is failed if you change .URL in navigation .Menu.URL.

@halink0803 thanks for bringing it up.. it did flew over my head and it reminded me of a similar issue with another repo.. Thanks again!

@nonumeros nonumeros force-pushed the master branch 2 times, most recently from b999e3b to 6332891 Compare October 24, 2019 04:43
@nonumeros
Copy link
Author

@vjeantet are you still maintaining this theme? I'm just wondering because the last merge was done on 2018. There're quite a few outstanding issues that have come up ever since.

eternoendless added a commit to eternoendless/hugo-theme-casper that referenced this pull request Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants