Authoravatar Updates #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @vjeantet,
I found two small things that might be worth a pull request if you feel so as well.
When you started using partials and introduced the author partial it was either authoravatar if an author was setup or the site's logo. For all other things such as author location it was either the authors location or the authorlocation from the site settings. I think this was an discrepancy and changed it to choose the authoravatar from the site settings as well instead of the logo.
The cover layout showed the Logo with a span of the Authors name. In most cases I would assume the Logo is not the Authors picture. So I changed it to be the site's title to have a better connection between the two things.
Thanks