Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'disqus' comment feature to each page #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

singleye
Copy link

Hi,

I use docdock for some time, and I miss the comment feature like 'disqus' which is useful for document sharing. This pull request adds the 'disqus' commenting feature.

It works this way:

  1. To enable the feature, add ''disqusShortname' into 'config.toml' or each page's param field. Empty or missing such config would disable the feature.
  2. Each page has higher priority than global config. And it could be specified a different short name consider that single page is created by another people in the team.
  3. It falls back to the global config.toml if the page's config is missing.

I've tested with both original/flex themes.

Thanks,

@vjeantet
Copy link
Owner

Hello, i'm ready to merge your good PR !

Why mathjax ?

@Pilskalns
Copy link

Hi @singleye,

Could you clear up this PR to have only Disqus commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants