Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown option for selecting the year #25

Closed
wants to merge 8 commits into from
Closed

Dropdown option for selecting the year #25

wants to merge 8 commits into from

Conversation

hahmadia
Copy link

@hahmadia hahmadia commented Nov 6, 2017

Hello!

When working with the calendar component, I realised that the year selection slider could at times be annoying. It was hard to select a year when the range of years was a lot and especially on small screen phones, it could be a pain to get the accurate date.

That is why I decided to add an optional prop for making the year selection either through a slider or a dropdown menu. Now you have the ability to select the year through the default slider or decide to use the dropdown instead.

image

Also, I experienced issues with sliding between months on android phone so I have temporarily disabled it in this pull request as well. (Related to issue #11). If someone fixes it, they can enable it again and make a pull request for that issue.

Hoping that my pull request can get approved and merged into master! Thank you!

@difeigu
Copy link

difeigu commented Nov 6, 2017

+1 this looks like a nice implementation

@hahmadia
Copy link
Author

hahmadia commented Nov 10, 2017

This is what it looks on android before you have opened the dropdown. When you click on the highlighted blue box, then the modal open.

When the modal open, it looks like this:

This makes it a lot easier to select the dates.

@bhartisahil
Copy link

+1 I hope this gets merged as it seems to be a very nice feature.

@hahmadia hahmadia closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants