Ready for ignoring same value mutations (#53)

dist/index.d.ts

@@ -124,5 +124,5 @@ export declare const select: <T extends object, MP extends SelectorMappingBase<T
     dispose: () => void;
 };
 export declare const inversePatch: (patch: JSONPatchEnhanced) => JSONPatchEnhanced;
-export declare const LIB_VERSION = "2.0.4beta";
+export declare const LIB_VERSION = "2.0.5beta";
 export {};

package.json

@@ -1,6 +1,6 @@
 {
   "name": "proxy-live-document",
-  "version": "2.0.4beta",
+  "version": "2.0.5beta",
   "description": "Mutable, observable, patchable JSON state wrapped in Smart Domains",
   "types": "dist/index.d.ts",
   "main": "dist/index.main.js",

src/index.ts

@@ -859,4 +859,4 @@ export const inversePatch = (patch: JSONPatchEnhanced): JSONPatchEnhanced => {
   }
 }
 
-export const LIB_VERSION = '2.0.4beta'
+export const LIB_VERSION = '2.0.5beta'

src/mutation-map.ts

@@ -106,6 +106,10 @@ export const createMutaitonInMutationTree = (
     newValue: unknown,
     opCount: number
 ) => {
+    // don't create mutation if old and new value are the same
+    if ( oldValue === newValue ) {
+        return
+    }
     // 1. check if this node contains an operation
     if ( "op" in mutationNode ) {
         // if the new value is NO_VALUE, it means we are deleting
@@ -308,6 +312,7 @@ const recursiveApplyChanges = (mutationNode: MutationTreeNode) => {
 
 
 export const getPatchesFromMutationTree = (mutationNode: MutationTreeNode) => {
+
     const patches: Array<JSONPatchEnhanced & {opCount : number }> = []
     accumulatePatchesFromMutationTree(mutationNode, patches)
     return patches.sort((a, b) => a.opCount - b.opCount).map((patch) => {

tests/mutate-from-patches.test.ts

@@ -118,11 +118,12 @@ describe('mutate from patches', () => {
     expect(observableCallback).toHaveBeenCalledTimes(1)
 
     const patches3 = mutate(doc, (modifiable) => {
-      modifiable.nodes['id1'].operationThatChangesInternalTypeTheRightWay('changed-via-method')
+      modifiable.nodes['id1'].operationThatChangesInternalTypeTheRightWay('ceva?')
     })
 
-    mutateFromPatches(otherDoc, patches3!)
     expect(node2).toHaveProperty('type', 'changed-via-method')
+    mutateFromPatches(otherDoc, patches3!)
+    expect(node2).toHaveProperty('type', 'ceva?')
     expect(observableCallback).toHaveBeenCalledTimes(2)
   })
 

tests/mutate-patch-order.test.ts

@@ -32,7 +32,8 @@ describe.only('patch order from mutations', () => {
         name: 'c',
         parentId: 'a'
     }
-    const patches = mutate(document, (modifiable) => {
+    const docClone = JSON.parse(JSON.stringify(document))
+    const patches = mutate(docClone, (modifiable) => {
         // order of the operations is important
         // the const parent here is needed before 
         // the change is made
@@ -41,10 +42,28 @@ describe.only('patch order from mutations', () => {
         parent.children[newNodeC.id] = true
     })
 
-    console.log('patches', patches)
+    // console.log('patches', patches)
     expect(patches).toHaveLength(2)
     expect(patches![0].path).toEqual('/nodes/c')
     expect(patches![1].path).toEqual('/nodes/a/children/c')
   })
 
+  it('does not generate patch if the old and new value are the same', () => {
+    const docClone = JSON.parse(JSON.stringify(document))
+
+    const patches = mutate(docClone, (modifiable) => {
+      modifiable.nodes.a.name = 'a'
+    })
+    expect(patches).toHaveLength(0)
+  })
+
+  it('does not generate patch if delete key does not exist', () => {
+    const docClone = JSON.parse(JSON.stringify(document))
+
+    const patches = mutate(docClone, (modifiable) => {
+      delete modifiable.nodes.x
+    })
+    expect(patches).toHaveLength(0)
+  })
+
 })

tests/tasklistapp.test.ts

@@ -321,7 +321,7 @@ describe('Task List project test suite', () => {
       const myNewTask = new Task(`3213421451212`, 'Buy bread')
       doc.addTask(myNewTask)
     })
-    expect(taskListProject.taskHierarchy.root).toEqual(patches![1].value)
+    expect(taskListProject.taskHierarchy.root['3213421451212']).toEqual(patches![1].value)
   })
 
 })