checker: fix missing check for concrete type on match branch expr #23508
+64
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: V_0.6-21937 |
|
(the CI failure is unrelated and already fixed on master) |
spytheman
reviewed
Jan 18, 2025
| @@ -0,0 +1,7 @@ | |||
| vlib/v/checker/tests/match_generic_case_err.vv:16:4: error: return type mismatch, it should be `int` | |||
There was a problem hiding this comment.
That seems a bit unclear 🤔
Can the error also show the type that the compiler thinks v is too?
Something like this can be less puzzling:
vlib/v/checker/tests/match_generic_case_err.vv:16:4: error: return type mismatch, it should be `int`, but it is instead `string`
There was a problem hiding this comment.
(not in the same PR, but in general)
There was a problem hiding this comment.
especially for generic code, I think it will help a lot
spytheman
reviewed
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23506