Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare vm_service as a dev dependency #4

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

mernen
Copy link
Contributor

@mernen mernen commented Feb 15, 2024

A quick adjustment: since vm_service is only used in tests, there's no need to make all users of autoclose depend on it.

@vlastachu
Copy link
Owner

Good advice! As far as I remember, I could not do this at the development stage because tests intended for the garbage collector can only be run in debug mode. Running tests in debug mode is impossible, so they are launched as a program launch in debugging. You can avoid this dependency by separating a new package for tests with a garbage collector.

@vlastachu
Copy link
Owner

I see no reason why my confirmation is required to start GitHub actions.

And why it wasn't failed)

@mernen
Copy link
Contributor Author

mernen commented Feb 26, 2024

As far as I remember, I could not do this at the development stage because tests intended for the garbage collector can only be run in debug mode. Running tests in debug mode is impossible, so they are launched as a program launch in debugging.

Oh, I see in the CI workflow it's running via dart run rather than dart test; I hadn't noticed that. Still, since this file is located in /test, it should be fine. (Notice this same file also imports package:test, which is a dev_dependency).

I see no reason why my confirmation is required to start GitHub actions.

This was a change issued by GitHub in recent years to curb abuse. IIRC, bots were sending pull requests with workflows that run crypto miners to use others' build minutes.

@vlastachu
Copy link
Owner

since this file is located in /test, it should be fine.

Wow. So this is how it works. I'm bad with dev_dependency part

I'm glad I do not have to do a new package to separate test deps.

@vlastachu vlastachu merged commit 53bfa17 into vlastachu:main Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants