Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Spec decode] Move drafter to model runner #13363

Merged
merged 12 commits into from
Feb 17, 2025
Merged

[V1][Spec decode] Move drafter to model runner #13363

merged 12 commits into from
Feb 17, 2025

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Feb 16, 2025

This PR moves the speculative decoding drafter, from the engine core to the model runner. At the end of each step, taking the large model’s outputs or hidden states, the spec decoding drafter generates extra "unverified" tokens. Those extra tokens are scheduled and verified in the next step, and in this same step, the spec decoding method generates new extra tokens again.

@mergify mergify bot added the v1 label Feb 16, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@WoosukKwon WoosukKwon marked this pull request as ready for review February 17, 2025 19:20
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 17, 2025
@WoosukKwon
Copy link
Collaborator Author

cc @LiuXiaoxuanPKU

Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Copy link
Collaborator

@LiuXiaoxuanPKU LiuXiaoxuanPKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for moving the propose logic to the end of model runner!

vllm/v1/worker/gpu_model_runner.py Show resolved Hide resolved
@WoosukKwon WoosukKwon merged commit cd4a72a into main Feb 17, 2025
37 of 44 checks passed
@WoosukKwon WoosukKwon deleted the v1-spec-decode branch February 17, 2025 23:40
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants