Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests. #498

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Add tests. #498

merged 2 commits into from
Oct 25, 2018

Conversation

H1Gdev
Copy link
Collaborator

@H1Gdev H1Gdev commented Oct 20, 2018

H1Gdev added 2 commits October 20, 2018 09:43
@H1Gdev
Add test.
95e5019 
- Override joi global options.
@H1Gdev
Add tests.
fb0458e 
- Test special character &.
@H1Gdev H1Gdev requested a review from vlucas October 20, 2018 00:50
@vlucas
Copy link
Owner

vlucas commented Oct 25, 2018

Looks good. Thanks for the additional coverage! 👍

@vlucas vlucas merged commit b6b5a4d into vlucas:master Oct 25, 2018
@H1Gdev H1Gdev deleted the tests branch October 25, 2018 22:22
@H1Gdev H1Gdev mentioned this pull request Oct 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlucas vlucas Awaiting requested review from vlucas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H1Gdev @vlucas