Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use localStorage for memqueue tests instead of Redis for #162 #163

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

shaunco
Copy link
Contributor

@shaunco shaunco commented Nov 21, 2021

Structured similarly to how #106 moved storage to storage.go, but I made a few changes:

  • Added NewLocalStorage() function to allow taskq users to do opt.Storage = taskq.NewLocalStorage(), as I agree with your comment in fixed panics on msg.Name != "" & redis is disabled #106 that introducing a new default will be unexpected by most and I'd also rather see an error when storage is not configured
  • NewLocalStorage() and newRedisStorage() return Storage interfaces instead of their internal types
  • Exist methods take pointers for their receiver argument, since LocalStorage would otherwise pass its sync.Mutex by value

@shaunco
Copy link
Contributor Author

shaunco commented Nov 21, 2021

Let me know if you want me to fix the commitlint complaint (subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]), even though it is complaining about localStorage and Redis, which should have those specific cases 😩

@vmihailenco
Copy link
Owner

Thanks 👍

@vmihailenco vmihailenco merged commit 720ffc5 into vmihailenco:v3 Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants