libudis86: introduce asmvprintf hook #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce asmvprintf hook to implement custom assembly code printing procedure with the help of udis86 builtin syntax formatting machanism. For syn-intel/att.c code, a syntax element type (enum ud_syn_class) is passed as the second argument on each calls to asmprintf(). An example of colorized assembly code output is implemented in udcli.c Signed-off-by: vardyh <[email protected]>
|
Hi Vardyh, this is a great change! I apologize for not responding sooner. My only hesitation is with how you disable auto-translate. I think this should be handled properly in the library/api, not something a client does. Let me think about how I can make it easy for you to do this, and merge your change after that. |
|
Hi Vivek, yeah it's true that auto-translate disabling is not implemented in this commit. I did that in the client by setting the translator to NULL, and it's really ugly, and indeed it should not be done like that. Well, let me think about it over and see if there's any better idea of doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce asmvprintf hook to implement custom assembly code printing
procedure with the help of udis86 builtin syntax formatting machanism.
For syn-intel/att.c code, a syntax element type (enum ud_syn_class)
is passed as the second argument on each calls to asmprintf().
An example of colorized assembly code output is implemented in udcli.c
Signed-off-by: vardyh [email protected]