This repository has been archived by the owner on Mar 17, 2022. It is now read-only.
Remove mixin retina-sprite's $dimensions parameter #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At commit 21c5888 a new parameter, $dimensions, was introduced in the central mixin: retina-sprite. Adding $dimensions before the $hover and $active parameters breaks all existing mixin calls which followed the old mixin signature. That change also broke cross-compatibility with @AdamBrodzinski's version, as all clients would need to change all their usages of the retina-sprite mixin if they had already specified arguments for $hover and $active. Moreover, the added parameter was undocumented and caused the demo to fail. If we want to introduce the new parameter, it should be added to the documentation, it's default value should be true, and it should be added as the last parameter to maintain backward compatibility.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At commit 21c5888 a new parameter, $dimensions, was introduced in the central mixin: retina-sprite. Adding $dimensions before the $hover and $active parameters breaks all existing mixin calls which followed the old mixin signature. That change also broke cross-compatibility with @AdamBrodzinski's version, as all clients would need to change all their usages of the retina-sprite mixin if they had already specified arguments for $hover and $active. Moreover, the added parameter was undocumented and caused the demo to fail. If we want to introduce the new parameter, it should be added to the documentation, it's default value should be true, and it should be added as the last parameter to maintain backward compatibility.