This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Use select_related if query contains foreign key references #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are directly making a db query if we get a property of a model which is declared as a foreign key. Example `os.name`. This makes the data retrieval very slow if we have many foreign key references since we execute seperate db queries. To avoid that we use select_related on queryset by default if we have foreign_key in the query. Additional changes: improve logging Fixes: #13 Signed-off-by: Priyank Singh <[email protected]>
Signed-off-by: Priyank Singh <[email protected]>
validate whether the queryset operation values passed by the client are of correct type or not. For example passing a string value in fields (`fields: 'name'`) is invalid, hence it should raise an `InvalidQueryException`. Added test cases Signed-off-by: Priyank Singh <[email protected]>
piyusql
reviewed
Apr 18, 2023
on every push Signed-off-by: Kartikeyan Gupta <[email protected]>
Implemented schema page functionality to show apps, models and fields available in the application. This page is only accessible by user with staff access and it will act as documentation for making BridgeQL API requests. Signed-off-by: Vidya Sagar <[email protected]>
display which operation has invalid type and what should be the expected type for a queryset operation Signed-off-by: Priyank Singh <[email protected]>
|
@preyunk, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are directly making a db query if we get a property of a model which is declared as a foreign key. Example
os.name. This makes the data retrieval very slow if we have many foreign key references since we execute seperate db queries. To avoid that we use select_related on queryset by default if we have foreign_key in the query.Additional changes: improve logging
Fixes: #13
Signed-off-by: Priyank Singh [email protected]