APF-1357 Addresses review comments.

samples/node/connector.js

@@ -28,14 +28,15 @@ app.use(['/cards/requests', '/reports'], function (req, res, next) {
     if (authorization) {
         console.log(`Client passed "${authorization}". We should authenticate using a public key from VMware Identity Manager`);
     } else {
-        res.status(401).send("Missing Authorization header");
-        return
+        return res.status(401).send("Missing Authorization header");
     }
     if (xAuthorization) {
         console.log(`Client passed "${xAuthorization}". Connector will use this to fetch info. form the backend Weather system.`);
         next();
     } else {
-        res.status(400).send("Missing X-Connector-Authorization header");
+        const r = res.status(400);
+        r.setHeader('X-Backend-Status', 401);
+        r.send("Missing X-Connector-Authorization header");
     }
 });
 

samples/node/package.json

@@ -8,10 +8,9 @@
     "start": "node connector.js"
   },
   "dependencies": {
-    "express" : "4.15.x",
-    "body-parser" : "1.17.x",
-    "command-line-args" : "4.0.x",
-    "uuid" : "3.0.x",
-    "halberd": "0.2.x"
+    "express": "4.15.x",
+    "body-parser": "1.17.x",
+    "command-line-args": "4.0.x",
+    "uuid": "3.0.x"
   }
 }

samples/node/routes/discovery.js

@@ -5,16 +5,24 @@
 
 "use strict";
 
-const fs = require('fs');
-
 exports.root = function (req, res) {
     const base = `${protocol(req)}://${host(req)}`;
-    fs.readFile('./discovery/metadata.json', 'utf8', function (err, contents) {
-        res.setHeader('Content-Type', 'application/json');
-        res.send(
-            contents.replace(new RegExp('@@_CONNECTOR_HOST_@@', 'g'), base)
-        );
-    });
+    const body = {
+        image: {href: `${base}/images/connector.png`},
+        test_auth: {href: `${base}/test-auth`},
+        object_types: [
+            {
+                name: "card",
+                doc: {href: "https://github.com/vmwaresamples/card-connectors-guide/wiki/Card-Responses"},
+                fields: {
+                    zip: {capture_group: 1, regex: "([0-9]{5})(?:[- ][0-9]{4})?"}
+                },
+                endpoint: {href: `${base}/cards/requests`}
+            }
+        ]
+    };
+    res.setHeader('Content-Type', 'application/json');
+    res.send(body);
 };
 
 function protocol(req) {