Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Cache node and overview information per poll_cycle #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cache node and overview information per poll_cycle #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a773450
only poll node info once
carlhoerberg Aug 5, 2015
1e9a5a1
only poll /overview once
carlhoerberg Aug 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions plugins/pivotal_rabbitmq_plugin/pivotal_rabbitmq_plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def poll_cycle
puts "[RabbitMQ] Debug Mode On: Metric data will not be sent to new relic"
end

@overview = rmq_manager.overview
report_metric_check_debug 'Queued Messages/Ready', 'messages', queue_size_ready
report_metric_check_debug 'Queued Messages/Unacknowledged', 'messages', queue_size_unacknowledged

Expand All @@ -56,11 +57,7 @@ def poll_cycle
report_metric_check_debug 'Message Rate/Publish', 'messages/sec', publish_rate
report_metric_check_debug 'Message Rate/Return', 'messages/sec', return_unroutable_rate

report_metric_check_debug 'Node/File Descriptors', 'file_descriptors', node_info('fd_used')
report_metric_check_debug 'Node/Sockets', 'sockets', node_info('sockets_used')
report_metric_check_debug 'Node/Erlang Processes', 'processes', node_info('proc_used')
report_metric_check_debug 'Node/Memory Used', 'bytes', node_info('mem_used')

report_node
report_queues

rescue Exception => e
Expand Down Expand Up @@ -91,7 +88,7 @@ def queue_size_for(type = nil)
totals_key = 'messages'
totals_key << "_#{type}" if type

queue_totals = rmq_manager.overview['queue_totals']
queue_totals = @overview['queue_totals']
if queue_totals.size == 0
$stderr.puts "[RabbitMQ] No data found for queue_totals[#{totals_key}]. Check that queues are declared. No data will be reported."
else
Expand Down Expand Up @@ -127,7 +124,7 @@ def publish_rate
end

def rate_for(type)
msg_stats = rmq_manager.overview['message_stats']
msg_stats = @overview['message_stats']

if msg_stats.is_a?(Hash)
details = msg_stats["#{type}_details"]
Expand All @@ -141,13 +138,13 @@ def return_unroutable_rate
rate_for 'return_unroutable'
end

#
# Node info
#
def node_info(key)
default_node_name = rmq_manager.overview['node']
node = rmq_manager.node(default_node_name)
node[key]
def report_node
default_node_name = @overview['node']
node_info = rmq_manager.node(default_node_name)
report_metric_check_debug 'Node/File Descriptors', 'file_descriptors', node_info['fd_used']
report_metric_check_debug 'Node/Sockets', 'sockets', node_info['sockets_used']
report_metric_check_debug 'Node/Erlang Processes', 'processes', node_info['proc_used']
report_metric_check_debug 'Node/Memory Used', 'bytes', node_info['mem_used']
end

def user_count
Expand Down