Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Optional failure for a tile that is already staged #352

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jhvhs
Copy link

@jhvhs jhvhs commented Aug 1, 2018

  • A short explanation of the proposed change:

Provide a flag that prevents false positives on the tile upgrade.

  • An explanation of the use cases your change solves:

When a tile has an upgrade pipeline, but the version has been updated manually for some reason, the pipeline would keep failing until a new version of the tile is published.

  • Expected result after the change:

When the operator sets the SKIP_IF_ALREADY_STAGED param for the stage-tile job to yes, and the latest matching tile version matches the version of the tile that has been manually installed, the upgrade pipeline does not fail, and does not attempt the upgrade.

  • Current result before the change:

When the newest available matching tile version coincides with the version currently installed, the pipeline would invariably fail.

  • Links to any other associated PRs or issues:

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the master branch

  • I have run all the unit tests

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants