Validates Deliverable flips to unknown #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waciumawanjohi
force-pushed
the
deliverable-goes-unknown
branch
from
bc2f73a to
187bc79
Compare
…ected field disappears
… when health updates
Avoids flakes where update is <1 sec causing time of last update to be equal
waciumawanjohi
force-pushed
the
deliverable-goes-unknown
branch
from
f762c94 to
7caeb6e
Compare
1 task
rashedkvm
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
Validates that a deliverable will flip from Ready==True to Ready==Unknown if a stamped object's health depends on a field which disappears. E.g. Succeeded condition goes from "True" to no longer being on the object.
Release Note
Cherry-pick branches
PR Checklist
Note: Please do not remove items. Mark items as done
[x]or usestrikethroughif you believe they are not relevantFixes #123orUpdates #123wipcommits[ ] Filled in the Release Note section above[ ] Added any relevant branches to cherry-pick[ ] Modified the docs to match changes