Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

Chore(tests, docs): Update after Knative func cli updates #147

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

joeeltgroth
Copy link
Contributor

@joeeltgroth joeeltgroth commented Oct 19, 2022

This commit updates documentation to account for the latest version of https://github.com/knative/func which has requirements for valid func.yaml files. It also removes func.yaml files and updates tests to use the BP_FUNCTION environment variable.

Signed-off-by: Joe Eltgroth [email protected]

@joeeltgroth joeeltgroth marked this pull request as draft October 19, 2022 20:34
@bbtong
Copy link
Contributor

bbtong commented Oct 19, 2022

Fixes #55

@joeeltgroth joeeltgroth force-pushed the je/update-docs-for-func-yaml branch 4 times, most recently from ae29c06 to 76eae9d Compare October 20, 2022 21:23
@joeeltgroth joeeltgroth changed the title Update docs after knative func cli updates Update after Knative func cli updates Oct 20, 2022
@joeeltgroth joeeltgroth changed the title Update after Knative func cli updates Chore(tests, docs): Update after Knative func cli updates Oct 20, 2022
This commit updates documentation to account for the latest version of https://github.com/knative/func which has requirements for valid func.yaml files. It also removes func.yaml files and updates tests to use the BP_FUNCTION environment variable.

Signed-off-by: Joe Eltgroth <[email protected]>
@joeeltgroth joeeltgroth force-pushed the je/update-docs-for-func-yaml branch from 76eae9d to 00451d4 Compare October 20, 2022 21:42
@joeeltgroth joeeltgroth marked this pull request as ready for review October 21, 2022 13:42
Copy link
Contributor

@andrew-su andrew-su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@andrew-su andrew-su merged commit d6bc0e5 into main Oct 21, 2022
@andrew-su andrew-su deleted the je/update-docs-for-func-yaml branch October 21, 2022 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants