This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Update Java buildpack detect and build #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-su
force-pushed
the
suan/update-java-buildpack
branch
from
3169439 to
8b7067d
Compare
|
Noticed that during the pack build of a function created via But, since this is Java, Python should be ignoring. See: PR #64 |
andrew-su
force-pushed
the
suan/update-java-buildpack
branch
2 times, most recently
from
b69c3fd to
39bad39
Compare
|
Some template tests are failing. Need to look into that. |
The detect now checks for func.yaml OR they explicitly defined an environment variable for the function class or the default function name. Signed-off-by: Andrew Su <[email protected]>
andrew-su
force-pushed
the
suan/update-java-buildpack
branch
from
39bad39 to
e88fe8a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes: #61
What this PR solves
This adds two configuration options for the buildpack.
BP_FUNCTIONto specify the composition of functions.BP_DEFAULT_FUNCTIONlets you specify the function reachable by/.Testing done
Tested it on our sample. (with func.yaml | it detects and builds the image)
Tested it on our sample. (without func.yaml | it fails detect, this was expected)
Tested it on our sample. (without func.yaml but specified env variables | it detects and builds the image)