[velero] Add helm annotation for velero.io/v1 schedule CRD #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@namm2, @reddiablo85 PTAL 🙇 |
|
I tested and it works fine. Thanks for the PR. |
carlisia
previously approved these changes
Sep 3, 2020
|
@jenting this will need a version bump please. |
This was referenced Sep 10, 2020
|
@carlisia @ashish-amarnath @nrb @cpanato PTAL 🙇 |
cpanato
reviewed
Sep 22, 2020
charts/velero/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v1 | |||
| appVersion: 1.4.2 | |||
| description: A Helm chart for velero | |||
| name: velero | |||
| version: 2.12.17 | |||
| version: 2.12.18 | |||
There was a problem hiding this comment.
this looks like a new feature I would bump to 2.13.0
There was a problem hiding this comment.
This is just a bug fix. I hope it could be merged as soon as possible.
There was a problem hiding this comment.
also would like to see it merged 👍 🙏
There was a problem hiding this comment.
@cpanato could you please take a look at this PR, thanks 🙇
cpanato
previously approved these changes
Sep 25, 2020
added 3 commits
October 5, 2020 15:55
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special notes for your reviewer:
fixes #151
fixes #152
fixes #160
fixes #165
fixes #167
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero])