-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ako crd to v1beta1 in akoo #172
Conversation
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 36.35% 36.27% -0.08%
==========================================
Files 20 20
Lines 2712 2715 +3
==========================================
- Hits 986 985 -1
- Misses 1667 1671 +4
Partials 59 59
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also make sure run
go mod tidy
controllers/akodeploymentconfig/akodeploymentconfig_controller_avi_phase.go
Show resolved
Hide resolved
baf223e
to
ccdd264
Compare
controllers/akodeploymentconfig/akodeploymentconfig_controller_avi_phase.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
75158ec
to
c76752b
Compare
controllers/akodeploymentconfig/akodeploymentconfig_controller_avi_phase.go
Outdated
Show resolved
Hide resolved
c76752b
to
dcb48e7
Compare
dcb48e7
to
0ad3de9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Migrate ako crd to v1beta1 in akoo
Which issue(s) this PR fixes:
Fixes #
Describe testing done for PR:
Special notes for your reviewer:
Release note:
New PR Checklist