Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ako crd to v1beta1 in akoo #172

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Conversation

chenlin07
Copy link
Contributor

@chenlin07 chenlin07 commented Oct 18, 2023

What this PR does / why we need it:

Migrate ako crd to v1beta1 in akoo

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

@chenlin07 chenlin07 changed the title Update v1beta1 ako crd in akoo Migrate ako crd to v1beta1 in akoo Oct 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #172 (0ad3de9) into main (50b8bc6) will decrease coverage by 0.08%.
The diff coverage is 36.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   36.35%   36.27%   -0.08%     
==========================================
  Files          20       20              
  Lines        2712     2715       +3     
==========================================
- Hits          986      985       -1     
- Misses       1667     1671       +4     
  Partials       59       59              
Files Coverage Δ
...andlers/cluster_for_akodeploymentconfig_handler.go 64.28% <100.00%> (ø)
pkg/handlers/cluster_for_machine_handler.go 79.06% <100.00%> (-0.48%) ⬇️
api/v1alpha1/akodeploymentconfig_webhook.go 78.29% <90.00%> (ø)
controllers/machine/machine_controller.go 0.00% <0.00%> (ø)
pkg/haprovider/haprovider.go 68.03% <33.33%> (ø)
controllers/cluster/cluster_controller.go 0.00% <0.00%> (ø)
...deploymentconfig/akodeploymentconfig_controller.go 0.00% <0.00%> (ø)
...config/akodeploymentconfig_controller_avi_phase.go 19.21% <0.00%> (-0.24%) ⬇️

Copy link
Member

@XudongLiuHarold XudongLiuHarold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure run

go mod tidy

@chenlin07 chenlin07 force-pushed the topic/chenlin/update-v1beta1 branch 2 times, most recently from baf223e to ccdd264 Compare October 23, 2023 08:01
Copy link
Member

@XudongLiuHarold XudongLiuHarold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@chenlin07 chenlin07 force-pushed the topic/chenlin/update-v1beta1 branch from 75158ec to c76752b Compare October 26, 2023 02:59
@chenlin07 chenlin07 force-pushed the topic/chenlin/update-v1beta1 branch from dcb48e7 to 0ad3de9 Compare October 27, 2023 03:59
Copy link
Member

@XudongLiuHarold XudongLiuHarold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenlin07 chenlin07 merged commit 1c17e4c into main Oct 27, 2023
@chenlin07 chenlin07 deleted the topic/chenlin/update-v1beta1 branch October 27, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants