Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster IP Family check #176

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Cluster IP Family check #176

merged 1 commit into from
Nov 28, 2023

Conversation

chenlin07
Copy link
Contributor

@chenlin07 chenlin07 commented Nov 28, 2023

What this PR does / why we need it:

AKO won't be installed in IPv6 single-stack and IPv6 Primary dual-stack cluster

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Manually test in testbed. ako is not deployed in ipv6 primary dual-stack cluster, there is error log in ako operator

2023-11-28T10:21:21.889Z	ERROR	controllers.AKODeploymentConfig	cluster default-test's ip family is not allowed, stop deploying AKO into cluster default-test	{"AKODeploymentConfig": {"name":"install-ako-for-all"}, "cluster": "default/test", "error": "AKO doesn't work in IPv6 single-stack and IPv6 Primary dual-stack cluster"}
github.com/vmware-tanzu/load-balancer-operator-for-kubernetes/controllers/akodeploymentconfig/cluster.(*ClusterReconciler).ReconcileAddonSecret

cluster condition

- lastTransitionTime: "2023-11-28T10:15:35Z"
    message: cluster default-test's ip family is not allowed, stop deploying AKO into
      cluster default-test
    status: "False"
    type: ClusterIpFamilyValidationSucceeded

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

@codecov-commenter
Copy link

Codecov Report

Merging #176 (297e15c) into main (8f0289d) will not change coverage.
The diff coverage is 73.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   36.27%   36.27%           
=======================================
  Files          20       20           
  Lines        2721     2721           
=======================================
  Hits          987      987           
  Misses       1675     1675           
  Partials       59       59           
Files Coverage Δ
...tconfig/cluster/cluster_controller_addon_secret.go 14.44% <73.33%> (ø)

Copy link
Member

@XudongLiuHarold XudongLiuHarold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Chen

@chenlin07 chenlin07 merged commit ce32f01 into main Nov 28, 2023
4 checks passed
@chenlin07 chenlin07 deleted the topic/chenlin/v6-check branch November 28, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants