Ensure GetControlPlaneEndpoint can still return an IP #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the cluster-controlplane-endpoint annotation or ClusterClass topology variable for apiServerEndpoint are not set, it can still retrieve the control plane endpoint from the cluster.Spec.ControlPlaneEndpoint.Host. Co-authored-by: Aidan Obley <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 36.27% 36.34% +0.07%
==========================================
Files 20 20
Lines 2721 2724 +3
==========================================
+ Hits 987 990 +3
Misses 1675 1675
Partials 59 59
|
- Modifying the cluster object directly in Golang also somehow modifies it on the fake API side
lubronzhan
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the cluster-controlplane-endpoint annotation or ClusterClass topology variable for apiServerEndpoint are not set, it can still retrieve the control plane endpoint from the
cluster.Spec.ControlPlaneEndpoint.Host.What this PR does / why we need it:
This change mitigates the situation in which a user might accidentally delete the control plane HA service for the cluster and for some reason the cluster-controlplane-endpoint annotation or ClusterClass topology variable for apiServerEndpoint are not set.
Which issue(s) this PR fixes:
Fixes #
Describe testing done for PR:
Manually verified on a testbed with Avi + AKO.
apiServerEndpointtopology variable and deleted the control plane HA serviceSpecial notes for your reviewer:
Release note:
New PR Checklist