Bugfix: Call waitgroup.Add before any consumption on the waitgroup in…

… VPC service initialization (#945)
vmware-tanzu · Dec 6, 2024 · 21d1300 · 21d1300
1 parent 12859ca
commit 21d1300
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/nsx/services/vpc/vpc.go b/pkg/nsx/services/vpc/vpc.go
@@ -162,11 +162,13 @@ func InitializeVPC(service common.Service) (*VPCService, error) {
 	VPCService.VPCNSNetworkConfigStore = VPCNsNetworkConfigStore{
 		VPCNSNetworkConfigMap: make(map[string]string),
 	}
+
+	// Note: waitgroup.Add must be called before its consumptions.
+	wg.Add(2)
 	// initialize vpc store, lbs store
 	go VPCService.InitializeResourceStore(&wg, fatalErrors, common.ResourceTypeVpc, nil, VPCService.VpcStore)
 	go VPCService.InitializeResourceStore(&wg, fatalErrors, common.ResourceTypeLBService, nil, VPCService.LbsStore)
 
-	wg.Add(2)
 	go func() {
 		wg.Wait()
 		close(wgDone)