Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check 5 GPRRs for VPC RealizedState #1017

Closed
wants to merge 1 commit into from

Conversation

yanjunz97
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.98%. Comparing base (372154d) to head (4e4c829).

Files with missing lines Patch % Lines
pkg/nsx/services/vpc/vpc.go 92.30% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v4.2.0    #1017      +/-   ##
==========================================
+ Coverage   74.86%   74.98%   +0.12%     
==========================================
  Files         118      118              
  Lines       16409    16432      +23     
==========================================
+ Hits        12285    12322      +37     
+ Misses       3357     3343      -14     
  Partials      767      767              
Flag Coverage Δ
unit-tests 74.98% <94.11%> (+0.12%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/services/common/types.go 100.00% <ø> (ø)
pkg/nsx/services/realizestate/realize_state.go 100.00% <100.00%> (ø)
pkg/nsx/services/subnet/subnet.go 70.27% <100.00%> (ø)
pkg/nsx/services/subnetport/subnetport.go 82.56% <100.00%> (ø)
pkg/nsx/util/utils.go 89.17% <ø> (ø)
pkg/nsx/services/vpc/vpc.go 57.43% <92.30%> (+2.34%) ⬆️

@yanjunz97 yanjunz97 marked this pull request as draft January 27, 2025 10:42
@yanjunz97 yanjunz97 marked this pull request as ready for review February 5, 2025 07:12
@yanjunz97 yanjunz97 closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants