Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add staticroute e2e test #685

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Aug 13, 2024

staticroute e2e test

@timdengyun
Copy link
Contributor

/e2e

Copy link
Contributor

@zhengxiexie zhengxiexie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add 3 cases, staticroute for ip block visibility -- Private, External, None
Refer #626

@zhengxiexie
Copy link
Contributor

/e2e

@TaoZou1 TaoZou1 force-pushed the staticroutee2e branch 2 times, most recently from 4063b71 to eb71c9b Compare November 5, 2024 08:30
Add staticroute e2e test
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (2b6d1b7) to head (1a30a95).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
- Coverage   70.63%   70.61%   -0.02%     
==========================================
  Files          95       95              
  Lines       15077    15094      +17     
==========================================
+ Hits        10649    10658       +9     
- Misses       3704     3710       +6     
- Partials      724      726       +2     
Flag Coverage Δ
unit-tests 70.61% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
pkg/nsx/services/common/types.go 100.00% <ø> (ø)
pkg/nsx/services/staticroute/staticroute.go 77.27% <100.00%> (ø)

... and 2 files with indirect coverage changes

@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Nov 12, 2024

/e2e

1 similar comment
@zhengxiexie
Copy link
Contributor

/e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants