[e2e] Use Subnet UID to get NSX resources in the test #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 118 118
Lines 16390 16390
=======================================
Hits 12034 12034
Misses 3571 3571
Partials 785 785
|
|
/e2e |
2 similar comments
|
/e2e |
|
/e2e |
wenyingd
dismissed stale reviews from timdengyun and zhengxiexie
via
354515a
The flaky issue may happen if stale VpcSubnet resources exist on NSX in anohter VPC configured with the same Namespace name. The fix is using the tested Subnet CR's UID to get NSX resources. This is because the K8s can ensure the CR's UID is unique.
yanjunz97
approved these changes
Dec 12, 2024
|
/e2e |
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Dec 12, 2024
The flaky issue may happen if stale VpcSubnet resources exist on NSX in anohter VPC configured with the same Namespace name. The fix is using the tested Subnet CR's UID to get NSX resources. This is because the K8s can ensure the CR's UID is unique.
wenyingd
added a commit
that referenced
this pull request
Dec 12, 2024
The flaky issue may happen if stale VpcSubnet resources exist on NSX in anohter VPC configured with the same Namespace name. The fix is using the tested Subnet CR's UID to get NSX resources. This is because the K8s can ensure the CR's UID is unique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flaky issue may happen if the stale VpcSubnet resources exist on NSX in anohter VPC configured with the same Namespace name.
The fix is using the tested Subnet CR's UID to get NSX resources. This is because the K8s can ensure the CR's UID is unique.
Fix: #956