Add StoragePolicy and ContentLibrary when creating VC Namespace #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 73.37% 73.43% +0.05%
==========================================
Files 118 118
Lines 16394 16362 -32
==========================================
- Hits 12029 12015 -14
+ Misses 3581 3564 -17
+ Partials 784 783 -1
|
|
/e2e |
zhengxiexie
force-pushed
the
topic/zhengxie/main/policy
branch
from
2680212 to
149360a
Compare
|
/e2e |
zhengxiexie
force-pushed
the
topic/zhengxie/main/policy
branch
4 times, most recently
from
d9de4f6 to
49407d8
Compare
|
/e2e |
zhengxiexie
force-pushed
the
topic/zhengxie/main/policy
branch
from
49407d8 to
f5964fa
Compare
|
/e2e |
zhengxiexie
force-pushed
the
topic/zhengxie/main/policy
branch
from
f5964fa to
d040054
Compare
|
/e2e |
1 similar comment
|
/e2e |
wenyingd
reviewed
Jan 6, 2025
zhengxiexie
force-pushed
the
topic/zhengxie/main/policy
branch
from
d040054 to
b22303b
Compare
yes, that's true, added. |
zhengxiexie
force-pushed
the
topic/zhengxie/main/policy
branch
2 times, most recently
from
2a84019 to
dbfefd0
Compare
wenyingd
reviewed
Jan 6, 2025
zhengxiexie
force-pushed
the
topic/zhengxie/main/policy
branch
from
dbfefd0 to
bc3bd96
Compare
wenyingd
approved these changes
Jan 6, 2025
|
/e2e |
1 similar comment
|
/e2e |
seanpang-vmware
approved these changes
Jan 6, 2025
dantingl
reviewed
Jan 7, 2025
| @@ -307,17 +307,40 @@ func (data *TestData) createVCNamespace(namespace string) error { | |||
| }() | |||
|
|
|||
| svID, _ := data.vcClient.getSupervisorID() | |||
| storagePolicyID, _ := data.vcClient.getStoragePolicyID() | |||
There was a problem hiding this comment.
Will content library be heavy load or have performance for Namespace, can we add a parameter in createVCNamespace to add storage policy and content library only if they are needed in specific test cases?
zhengxiexie
added a commit
that referenced
this pull request
Jan 7, 2025
…ontent_lib [CP]Add StoragePolicy and ContentLibrary when creating VC Namespace(#975)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is prepared for VM creating in e2e test.
If we want create VM in a namespace, it should be created by VC API, the namespace should have Storage, ContentLibrary, and VmClass attached.