-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug which should delete node from store when node is not found #980
Conversation
5f9e3a0
to
5c774da
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
==========================================
+ Coverage 73.29% 73.37% +0.07%
==========================================
Files 118 118
Lines 16397 16401 +4
==========================================
+ Hits 12019 12035 +16
+ Misses 3591 3578 -13
- Partials 787 788 +1
|
28cc7ca
to
2ece25f
Compare
/e2e |
1 similar comment
/e2e |
2ece25f
to
defd8df
Compare
…und error When node is deleted, the phase node.ObjectMeta.DeletionTimestamp being not zero is intermittent, and it is more possible the node is not found, we should delete the node from store.
defd8df
to
5a770d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From the log, we can see when node is deleted, there is node not found error, and there are still two node ids in store.
The phase node.ObjectMeta.DeletionTimestamp being not zero is intermittent, and it is more possible the node is not found, we should delete the node from store.