Fix Subnet update error detection #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanjunz97
force-pushed
the
fix-subnet-update
branch
from
3f70328 to
1942e20
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
==========================================
+ Coverage 74.12% 74.22% +0.10%
==========================================
Files 118 118
Lines 16384 16378 -6
==========================================
+ Hits 12144 12157 +13
+ Misses 3466 3451 -15
+ Partials 774 770 -4
|
dantingl
reviewed
Jan 7, 2025
TaoZou1
reviewed
Jan 7, 2025
yanjunz97
force-pushed
the
fix-subnet-update
branch
4 times, most recently
from
ecf2948 to
eca3d76
Compare
dantingl
previously approved these changes
Jan 15, 2025
yanjunz97
force-pushed
the
fix-subnet-update
branch
3 times, most recently
from
61f5514 to
972aed5
Compare
TaoZou1
reviewed
Jan 16, 2025
Signed-off-by: Yanjun Zhou <[email protected]>
yanjunz97
force-pushed
the
fix-subnet-update
branch
from
972aed5 to
d94f593
Compare
TaoZou1
approved these changes
Jan 17, 2025
dantingl
approved these changes
Jan 17, 2025
yanjunz97
added a commit
to yanjunz97/nsx-operator
that referenced
this pull request
Jan 17, 2025
Operator modifies the existing Subnet in store before updating the NSX Subnet, which results in the next reconcile will find the updated Subnet already in store, skip the update, and overwrite the Status as Ready. This PR uses a copy when updating the Subnet to avoid this issue. Signed-off-by: Yanjun Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator modifies the existing Subnet in store before updating the NSX Subnet,
which results in the next reconcile will find the updated Subnet already in store,
skip the update, and overwrite the Status as Ready.
This PR uses a copy when updating the Subnet to avoid this issue.