Skip to content

Commit

Permalink
Clarify documentation for the advertised CA bundle of the impersonati…
Browse files Browse the repository at this point in the history
…on proxy
  • Loading branch information
joshuatcasey committed Dec 3, 2024
1 parent 46bbe5b commit 1958bb8
Show file tree
Hide file tree
Showing 25 changed files with 150 additions and 59 deletions.
9 changes: 6 additions & 3 deletions apis/concierge/config/v1alpha1/types_credentialissuer.go.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -83,23 +83,26 @@ const (
)

// ImpersonationProxyTLSSpec contains information about how the Concierge impersonation proxy should
// serve TLS.
// serve TLS and what CA bundle to advertise for TLS verification.
//
// If CertificateAuthorityData is not provided, the Concierge impersonation proxy will check the secret
// for a field called "ca.crt", which will be used as the CertificateAuthorityData.
// for a field called "ca.crt", which will be used as the CA bundle to advertise for TLS verification.
//
// If neither CertificateAuthorityData nor ca.crt is provided, no CA bundle will be advertised for
// the impersonation proxy endpoint.
type ImpersonationProxyTLSSpec struct {
// X.509 Certificate Authority (base64-encoded PEM bundle).
// Used to advertise the CA bundle for the impersonation proxy endpoint.
// Used to advertise the CA bundle for TLS verification.
//
// +optional
CertificateAuthorityData string `json:"certificateAuthorityData,omitempty"`

// SecretName is the name of a Secret in the same namespace, of type `kubernetes.io/tls`, which contains
// the TLS serving certificate for the Concierge impersonation proxy endpoint.
//
// If CertificateAuthorityData is not provided, the Concierge impersonation proxy will check this secret for
// a field called "ca.crt", which will be used as the CA bundle to advertise for TLS verification.
//
// +kubebuilder:validation:MinLength=1
SecretName string `json:"secretName,omitempty"`
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,16 @@ spec:
certificateAuthorityData:
description: |-
X.509 Certificate Authority (base64-encoded PEM bundle).
Used to advertise the CA bundle for the impersonation proxy endpoint.
Used to advertise the CA bundle for TLS verification.
type: string
secretName:
description: |-
SecretName is the name of a Secret in the same namespace, of type `kubernetes.io/tls`, which contains
the TLS serving certificate for the Concierge impersonation proxy endpoint.
If CertificateAuthorityData is not provided, the Concierge impersonation proxy will check this secret for
a field called "ca.crt", which will be used as the CA bundle to advertise for TLS verification.
minLength: 1
type: string
type: object
Expand Down
10 changes: 7 additions & 3 deletions generated/1.25/README.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions generated/1.26/README.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions generated/1.27/README.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions generated/1.28/README.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions generated/1.29/README.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1958bb8

Please sign in to comment.