Skip to content

Commit

Permalink
Merge pull request #1693 from vmware-tanzu/concierge_pods_priorityCla…
Browse files Browse the repository at this point in the history
…ssName

Stop using deprecated critical-pod annotation
  • Loading branch information
cfryanr authored Sep 26, 2023
2 parents d44882f + 192553a commit 7513092
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions deploy/concierge/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#! Copyright 2020-2022 the Pinniped contributors. All Rights Reserved.
#! Copyright 2020-2023 the Pinniped contributors. All Rights Reserved.
#! SPDX-License-Identifier: Apache-2.0

#@ load("@ytt:data", "data")
Expand Down Expand Up @@ -134,8 +134,6 @@ spec:
#! More recently added the more unique deploymentPodLabel() so Services can select these Pods more specifically
#! without accidentally selecting any other Deployment's Pods, especially the kube cert agent Deployment's Pods.
_: #@ template.replace(deploymentPodLabel())
annotations:
scheduler.alpha.kubernetes.io/critical-pod: ""
spec:
securityContext:
runAsUser: #@ data.values.run_as_user
Expand Down Expand Up @@ -247,9 +245,6 @@ spec:
effect: NoSchedule
- key: node-role.kubernetes.io/control-plane #! The new name for these nodes as of Kubernetes 1.24.
effect: NoSchedule
#! "system-cluster-critical" cannot be used outside the kube-system namespace until Kubernetes >= 1.17,
#! so we skip setting this for now (see https://github.com/kubernetes/kubernetes/issues/60596).
#!priorityClassName: system-cluster-critical
#! This will help make sure our multiple pods run on different nodes, making
#! our deployment "more" "HA".
affinity:
Expand Down

0 comments on commit 7513092

Please sign in to comment.