Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify buildtags and dockerfiles #1484

Closed
wants to merge 2 commits into from
Closed

Simplify buildtags and dockerfiles #1484

wants to merge 2 commits into from

Conversation

joshuatcasey
Copy link
Member

@joshuatcasey joshuatcasey commented Apr 8, 2023 •
edited
Loading

Simplify buildtags and dockerfiles.

Requires #1647 to be merged first.

@codecov
Copy link

codecov bot commented Apr 8, 2023 •
edited
Loading

Codecov Report

Merging #1484 (15a49ce) into main (1ac8691) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage   79.21%   79.21%           
=======================================
  Files         163      163           
  Lines       15758    15758           
=======================================
+ Hits        12482    12483    +1     
+ Misses       2961     2959    -2     
- Partials      315      316    +1
Files Changed Coverage Δ
cmd/pinniped-concierge-kube-cert-agent/main.go 100.00% <ø> (ø)
cmd/pinniped-server/main.go 100.00% <ø> (ø)
internal/crypto/ptls/default.go 100.00% <ø> (ø)
internal/crypto/ptls/secure.go 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@joshuatcasey joshuatcasey marked this pull request as draft July 28, 2023 17:04
@joshuatcasey joshuatcasey changed the title Simplify Tags Simplify buildtags and dockerfiles Aug 31, 2023
@joshuatcasey joshuatcasey marked this pull request as ready for review August 31, 2023 02:52
@joshuatcasey joshuatcasey force-pushed the jtc/fix-tags branch 2 times, most recently from e5fb05c to 76b6e4e Compare August 31, 2023 04:02
@cfryanr cfryanr marked this pull request as draft November 30, 2023 17:55
@joshuatcasey
Copy link
Member Author

closing due to no progress

@cfryanr cfryanr deleted the jtc/fix-tags branch June 21, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuatcasey @vmwclabot