Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny fixups to support #1548 #1549

Merged
merged 10 commits into from
Jul 19, 2023
Merged

Tiny fixups to support #1548 #1549

merged 10 commits into from
Jul 19, 2023

Conversation

joshuatcasey
Copy link
Member

@joshuatcasey joshuatcasey commented Jun 14, 2023 •
edited
Loading

Tiny fixups to support #1548

@joshuatcasey joshuatcasey changed the title Tiny fixups to support 1548 Tiny fixups to support #1548 Jun 14, 2023
@joshuatcasey joshuatcasey force-pushed the jtc/tiny-fixups-to-support-1548 branch from c78a479 to 47f9f26 Compare July 6, 2023 16:26
@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited
Loading

Codecov Report

Merging #1549 (3991206) into main (f6c2d40) will increase coverage by 0.07%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
+ Coverage   75.41%   75.49%   +0.07%     
==========================================
  Files         165      166       +1     
  Lines       14973    15011      +38     
==========================================
+ Hits        11292    11332      +40     
+ Misses       3387     3386       -1     
+ Partials      294      293       -1
Files Changed Coverage Δ
internal/certauthority/certauthority.go 94.40% <ø> (ø)
internal/concierge/server/server.go 18.18% <0.00%> (ø)
internal/config/concierge/config.go 92.24% <ø> (ø)
internal/controllerlib/manager.go 0.00% <ø> (ø)
...ntroller/impersonatorconfig/impersonator_config.go 92.18% <95.45%> (+<0.01%) ⬆️
internal/issuer/issuer.go 100.00% <100.00%> (ø)
internal/oidc/provider/federation_domain_issuer.go 86.04% <100.00%> (+8.54%) ⬆️

@joshuatcasey joshuatcasey force-pushed the jtc/tiny-fixups-to-support-1548 branch 3 times, most recently from bb373fa to 8111de0 Compare July 7, 2023 19:29
@joshuatcasey joshuatcasey force-pushed the jtc/tiny-fixups-to-support-1548 branch from 8111de0 to 3991206 Compare July 19, 2023 20:51
@joshuatcasey joshuatcasey enabled auto-merge July 19, 2023 21:10
@joshuatcasey joshuatcasey merged commit 6c329ba into main Jul 19, 2023
@joshuatcasey joshuatcasey deleted the jtc/tiny-fixups-to-support-1548 branch July 19, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfryanr cfryanr cfryanr approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshuatcasey @benjaminapetersen @cfryanr @vmwclabot