-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1633 Update pinniped version
output
#1634
#1633 Update pinniped version
output
#1634
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
+ Coverage 75.45% 75.51% +0.06%
==========================================
Files 166 167 +1
Lines 15082 15147 +65
==========================================
+ Hits 11380 11439 +59
- Misses 3403 3407 +4
- Partials 299 301 +2
|
414c046
to
4d6e361
Compare
4d6e361
to
38230fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice little polish.
For release notes, and for notifying downstream teams... This PR changes how the Dockerfile injects the version information into the binary. Anyone who is doing their own |
See #1633 for details.
Note that this does require #1630 to be merged first.