Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1633 Update pinniped version output #1634

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

joshuatcasey
Copy link
Member

See #1633 for details.

Note that this does require #1630 to be merged first.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1634 (2dcc149) into main (8edecff) will increase coverage by 0.06%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
+ Coverage   75.45%   75.51%   +0.06%     
==========================================
  Files         166      167       +1     
  Lines       15082    15147      +65     
==========================================
+ Hits        11380    11439      +59     
- Misses       3403     3407       +4     
- Partials      299      301       +2     
Files Changed Coverage Δ
internal/concierge/server/server.go 17.80% <0.00%> (ø)
cmd/pinniped/cmd/version.go 81.25% <76.00%> (-18.75%) ⬇️
internal/pversion/version.go 100.00% <100.00%> (ø)

@joshuatcasey joshuatcasey force-pushed the jtc/1633/update-pinniped-cli-version-output branch 4 times, most recently from 414c046 to 4d6e361 Compare August 26, 2023 21:58
oidc-auth0.yaml Outdated Show resolved Hide resolved
@joshuatcasey joshuatcasey force-pushed the jtc/1633/update-pinniped-cli-version-output branch from 4d6e361 to 38230fc Compare August 28, 2023 16:54
Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little polish.

@joshuatcasey joshuatcasey merged commit 9248db9 into main Aug 28, 2023
@joshuatcasey joshuatcasey deleted the jtc/1633/update-pinniped-cli-version-output branch August 28, 2023 19:19
@cfryanr
Copy link
Member

cfryanr commented Aug 29, 2023

For release notes, and for notifying downstream teams...

This PR changes how the Dockerfile injects the version information into the binary. Anyone who is doing their own docker build, or using their own custom Dockerfile, or building the CLI, will need to be aware that they will need to change how they inject the version number, if they choose to inject a version number, during builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants