Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple idps and identity transformations docs #1660

Merged
merged 1 commit into from
Sep 14, 2023
Merged

multiple idps and identity transformations docs #1660

merged 1 commit into from
Sep 14, 2023

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Sep 7, 2023

Website doc changes to go along with #1419.

Release note:

None, docs only.

NONE

@cfryanr cfryanr force-pushed the multiple_idps_and_transformations_docs branch 2 times, most recently from 21c8b37 to 992efb8 Compare September 7, 2023 16:32
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #1660 (84714a2) into main (5573c62) will decrease coverage by 3.66%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 84714a2 differs from pull request most recent head 54fb031. Consider uploading reports for the commit 54fb031 to get more accurate results

@@            Coverage Diff             @@
##             main    #1660      +/-   ##
==========================================
- Coverage   79.21%   75.55%   -3.66%     
==========================================
  Files         163      166       +3     
  Lines       15757    15159     -598     
==========================================
- Hits        12482    11454    -1028     
- Misses       2959     3404     +445     
+ Partials      316      301      -15

see 68 files with indirect coverage changes

@cfryanr cfryanr mentioned this pull request Sep 7, 2023
Merged
16 tasks
@cfryanr cfryanr force-pushed the multiple_idps_and_transformations_docs branch from 992efb8 to 6031b29 Compare September 11, 2023 16:31
@cfryanr cfryanr force-pushed the multiple_idps_and_transformations_docs branch from 6031b29 to fe48f6a Compare September 12, 2023 20:43
benjaminapetersen
benjaminapetersen reviewed Sep 13, 2023
View reviewed changes
site/content/docs/howto/supervisor/configure-supervisor-federationdomain-idps.md
e.g. one for each identity provider.

The remainder of this guide focuses on the second case, and describes the settings that may be used to explicitly
configure which identity providers are used, along with optional identity transformations and policies.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we want to point out the IdentityProvidersFound status here. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean here.

@cfryanr cfryanr force-pushed the multiple_idps_and_transformations_docs branch from fe48f6a to 7f3326f Compare September 13, 2023 16:27
benjaminapetersen
benjaminapetersen approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are tiny nit or "I'd love to break this up to make it easier for users to find specific features!", so nothing to really hold this PR back from merge once the feature merges.

🥳 🎉 🥳 🎉 🥳 🎉 🥳

site/content/docs/howto/supervisor/configure-supervisor-federationdomain-idps.md Show resolved Hide resolved
site/content/docs/howto/supervisor/configure-supervisor-federationdomain-idps.md Show resolved Hide resolved
@cfryanr cfryanr force-pushed the multiple_idps_and_transformations_docs branch 3 times, most recently from b048290 to 84714a2 Compare September 13, 2023 18:07
@cfryanr cfryanr force-pushed the multiple_idps_and_transformations_docs branch from 84714a2 to 66657bd Compare September 13, 2023 21:28
@cfryanr cfryanr force-pushed the multiple_idps_and_transformations_docs branch from 66657bd to 54fb031 Compare September 13, 2023 21:34
@cfryanr cfryanr merged commit efb53d3 into main Sep 14, 2023
7 checks passed
@cfryanr cfryanr deleted the multiple_idps_and_transformations_docs branch September 14, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuatcasey joshuatcasey joshuatcasey approved these changes

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfryanr @benjaminapetersen @joshuatcasey @vmwclabot