Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHubIdentityProvider #1898

Closed
wants to merge 1 commit into from
Closed

Conversation

joshuatcasey
Copy link
Member

See #1859

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 341 lines in your changes are missing coverage. Please review.

Project coverage is 37.96%. Comparing base (4465810) to head (8b8b1dd).

Files Patch % Lines
...s/supervisor/idp/v1alpha1/zz_generated.deepcopy.go 0.00% 111 Missing ⚠️
...ioned/typed/idp/v1alpha1/githubidentityprovider.go 0.00% 107 Missing ⚠️
...d/idp/v1alpha1/fake/fake_githubidentityprovider.go 0.00% 71 Missing ⚠️
...sor/listers/idp/v1alpha1/githubidentityprovider.go 0.00% 23 Missing ⚠️
...nalversions/idp/v1alpha1/githubidentityprovider.go 0.00% 21 Missing ⚠️
...rsioned/typed/idp/v1alpha1/fake/fake_idp_client.go 0.00% 2 Missing ⚠️
...ientset/versioned/typed/idp/v1alpha1/idp_client.go 0.00% 2 Missing ⚠️
...t/supervisor/informers/externalversions/generic.go 0.00% 2 Missing ⚠️
...formers/externalversions/idp/v1alpha1/interface.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
- Coverage   38.25%   37.96%   -0.29%     
==========================================
  Files         347      351       +4     
  Lines       44207    44548     +341     
==========================================
+ Hits        16910    16912       +2     
- Misses      26785    27123     +338     
- Partials      512      513       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey joshuatcasey force-pushed the github_identity_provider branch 3 times, most recently from 4ffb2f8 to a1d0594 Compare March 18, 2024 00:19
@benjaminapetersen
Copy link
Member

Nice, first Github PR in flight!

@joshuatcasey joshuatcasey force-pushed the github_identity_provider branch 4 times, most recently from 294b12e to fa07139 Compare March 19, 2024 15:41
@joshuatcasey joshuatcasey force-pushed the github_identity_provider branch from fa07139 to 8b8b1dd Compare March 19, 2024 16:25
@joshuatcasey
Copy link
Member Author

closing... new PRs for GitHub IDP should go into a feature branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants