Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to k8s 1.32 libs #2160

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Bump to k8s 1.32 libs #2160

wants to merge 9 commits into from

Conversation

joshuatcasey
Copy link
Member

Bump to k8s 1 32 libs.

See #2157 for context.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for pinniped-dev canceled.

Name Link
🔨 Latest commit eb27cd8
🔍 Latest deploy log https://app.netlify.com/sites/pinniped-dev/deploys/676ef962a4fdff000898f077

@joshuatcasey joshuatcasey changed the title Bump to k8s 1 32 libs Bump to k8s 1.32 libs Dec 16, 2024
@joshuatcasey joshuatcasey mentioned this pull request Dec 16, 2024
10 tasks
@joshuatcasey joshuatcasey force-pushed the jtc/bump-to-k8s-1-32-libs branch from 8e23937 to 9928c7e Compare December 17, 2024 21:29
hack/module.sh Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 37.86078% with 366 lines in your changes missing coverage. Please review.

Project coverage is 32.01%. Comparing base (fe75ebe) to head (2aea1c5).

Current head 2aea1c5 differs from pull request most recent head eb27cd8

Please upload reports for the commit eb27cd8 to get more accurate results.

Files with missing lines Patch % Lines
...t/client/concierge/openapi/zz_generated.openapi.go 0.00% 154 Missing ⚠️
.../client/supervisor/openapi/zz_generated.openapi.go 0.00% 154 Missing ⚠️
...login/v1alpha1/fake/fake_tokencredentialrequest.go 0.00% 8 Missing ⚠️
...cret/v1alpha1/fake/fake_oidcclientsecretrequest.go 0.00% 8 Missing ⚠️
...ed/authentication/v1alpha1/webhookauthenticator.go 0.00% 7 Missing ⚠️
...ed/idp/v1alpha1/activedirectoryidentityprovider.go 0.00% 7 Missing ⚠️
.../typed/authentication/v1alpha1/jwtauthenticator.go 0.00% 5 Missing ⚠️
...d/clientsecret/v1alpha1/oidcclientsecretrequest.go 0.00% 4 Missing ⚠️
...tset/versioned/typed/config/v1alpha1/oidcclient.go 0.00% 3 Missing ⚠️
...ioned/typed/idp/v1alpha1/githubidentityprovider.go 0.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2160      +/-   ##
==========================================
+ Coverage   31.95%   32.01%   +0.05%     
==========================================
  Files         379      379              
  Lines       62098    61659     -439     
==========================================
- Hits        19842    19738     -104     
+ Misses      41726    41410     -316     
+ Partials      530      511      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey joshuatcasey force-pushed the jtc/bump-to-k8s-1-32-libs branch from bb929d5 to 2aea1c5 Compare December 18, 2024 22:10
cfryanr added a commit that referenced this pull request Dec 19, 2024
@cfryanr cfryanr force-pushed the jtc/bump-to-k8s-1-32-libs branch from 2aea1c5 to 67df516 Compare December 23, 2024 19:43
@cfryanr
Copy link
Member

cfryanr commented Dec 23, 2024

I rebased this PR and also added a new commit. I expect that it will still fail unit tests due to the race detector finding the bug that exists in the v0.32.0 Kubernetes packages. We are hoping that the Kubernetes maintainers will release a fix for that bug soon.

@joshuatcasey joshuatcasey force-pushed the jtc/bump-to-k8s-1-32-libs branch from 67df516 to 8b1fa20 Compare December 27, 2024 18:09
@joshuatcasey joshuatcasey force-pushed the jtc/bump-to-k8s-1-32-libs branch from 8b1fa20 to eb27cd8 Compare December 27, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants