Fix missing org name in browser login #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Khouzam <[email protected]>
prkalle
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When doing an interactive login through a browser, the Tanzu Platform org name was no longer showing.
This PR fixes it.
Which issue(s) this PR fixes
Fixes # N/A
Describe testing done for PR
Before the PR, run
tanzu loginbuilt frommainand notice that the login succeeds but that the browser does not show the org name in the success message.Run
tanzu loginusing tanzu CLI v1.4.1 and notice that the org name is shown in the browser.Use this PR and run
tanzu loginand notice the org name is now shown again.Release note
Additional information
Special notes for your reviewer