Support login to UAA using API token #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuil
changed the title
vuil
force-pushed
the
uaa-api-token-login
branch
from
45623eb to
5a37a8a
Compare
vuil
changed the title
vuil
force-pushed
the
uaa-api-token-login
branch
from
5a37a8a to
1fa86db
Compare
vuil
changed the title
vuil
force-pushed
the
uaa-api-token-login
branch
3 times, most recently
from
506cd5a to
1e0a132
Compare
marckhouzam
reviewed
Oct 7, 2024
marckhouzam
reviewed
Oct 7, 2024
| @@ -20,6 +20,8 @@ const ( | |||
| extraIDToken = "id_token" | |||
| ) | |||
|
|
|||
| var currentTime = time.Now | |||
There was a problem hiding this comment.
Would you mind adding a comment to explain that currentTime is used to allow tests to override it?
There was a problem hiding this comment.
This will be removed and addressed as part of #820 (comment) by using separate package.
- enable the API token login flow for UAA. - sets token type to api-token - supports use of alternate client ID - update token refresh logic of UAA to use the alternate ID Signed-off-by: Vui Lam <[email protected]>
Signed-off-by: Vui Lam <[email protected]>
vuil
force-pushed
the
uaa-api-token-login
branch
from
1e0a132 to
dd641e4
Compare
marckhouzam
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Enables login via a previously obtained API token to a UAA based endpoint.
Also: fixed a bug where the expiration time on a token refresh is incorrect set to too close to current time.
Note : adding more tests and waiting for the alternative client id to be determined.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Obtain refresh token from CLI context
TANZU_API_TOKEN=obtainedtoken tanzu login --endpoint uaa-based-endpoint
Updated and ran unit tests.
Release note
Additional information
Special notes for your reviewer