Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UAA token refresh logic #826

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

vuil
Copy link
Contributor

@vuil vuil commented Oct 10, 2024

Ensures a pre-established, intentionally non-secret, string is used in the token exchange request as the client secret to ensure the refresh token obtained is reusable.

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

tanzu login --endpoint x
tanzu api-token create
TANZU_API_TOKEN=api_token_received tanzu login --endpoint x
verify additional attempts to reuse api token works, e.g. 
TANZU_API_TOKEN=api_token_received tanzu login --endpoint x
tanzu context get-token `tanzu context current --short`

Release note


Additional information

Special notes for your reviewer

@vuil vuil requested a review from a team as a code owner October 10, 2024 21:30
Ensures a pre-established, intentionally non-secret, string is used
in the token exchange request as the client secret to ensure the refresh
token obtained is reusable.

Signed-off-by: Vui Lam <[email protected]>
@vuil vuil force-pushed the uaa-nonrotating-refresh-token branch from 6242940 to ecfd7c2 Compare October 10, 2024 21:37
Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@vuil vuil merged commit e24f5d6 into vmware-tanzu:main Oct 10, 2024
7 checks passed
@marckhouzam marckhouzam added this to the v1.5.1 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants