Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiline prompt config support #216

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

gabbigum
Copy link
Contributor

@gabbigum gabbigum commented Oct 15, 2024

What this PR does / why we need it

Tanzu services plug-ins requires more multiline input for operations like configuring preprovisioned services with certificates.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Written unit tests + manual testing of survey.Multiline

Release note

Support `multiline = true` to PromptConfig and be able to add multiline strings as prompt inputs.

@gabbigum gabbigum requested a review from a team as a code owner October 15, 2024 14:31
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this.

@anujc25
Copy link
Contributor

anujc25 commented Oct 16, 2024

Looks like lint is failing because docker image is no longer present.

@gabbigum Can you please help update image (https://github.com/vmware-tanzu/tanzu-plugin-runtime/blob/main/hack/check/check-mdlint.sh#L19) to ghcr.io/vmware-tanzu/tanzu-cli/ci-images/mdlint:0.23.2 as part of this PR?

@anujc25 anujc25 merged commit 2641f40 into vmware-tanzu:main Oct 16, 2024
4 checks passed
@marckhouzam marckhouzam added this to the v1.5.0 milestone Oct 23, 2024
anujc25 pushed a commit to anujc25/tanzu-plugin-runtime that referenced this pull request Nov 5, 2024
* add multiline response support

* update mdlint with present docker image

---------

Co-authored-by: Gabriel Saliev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants